[15.0][MIG] contract_payment_mode #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Copy partner payment mode to contracts when installing * Filter payment modes for sales * Adding tests
in recurring invoice
Co-Authored-By: Pedro M. Baeza <[email protected]>
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: contract-12.0/contract-12.0-contract_payment_mode Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract_payment_mode/
Currently translated at 100.0% (2 of 2 strings) Translation: contract-12.0/contract-12.0-contract_payment_mode Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract_payment_mode/ca/
Currently translated at 100.0% (2 of 2 strings) Translation: contract-12.0/contract-12.0-contract_payment_mode Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract_payment_mode/pt_BR/
Currently translated at 100.0% (2 of 2 strings) Translation: contract-12.0/contract-12.0-contract_payment_mode Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract_payment_mode/zh_CN/
Currently translated at 100.0% (2 of 2 strings) Translation: contract-12.0/contract-12.0-contract_payment_mode Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract_payment_mode/de/
Currently translated at 100.0% (2 of 2 strings) Translation: contract-12.0/contract-12.0-contract_payment_mode Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract_payment_mode/pt/
Added view for supplier contracts, respecting the domain for payment_type. Before was showing the inbound types in the supplier payment
Currently translated at 100.0% (5 of 5 strings) Translation: contract-14.0/contract-14.0-contract_payment_mode Translate-URL: https://translation.odoo-community.org/projects/contract-14-0/contract-14-0-contract_payment_mode/es_AR/
Currently translated at 100.0% (2 of 2 strings) Translation: contract-14.0/contract-14.0-contract_payment_mode Translate-URL: https://translation.odoo-community.org/projects/contract-14-0/contract-14-0-contract_payment_mode/it/
|
This PR has the |
contract_payment_mode/hooks.py
Outdated
| if payment_mode: | ||
| contract.payment_mode_id = payment_mode.id | ||
| _logger.info("Setting payment mode: Done") | ||
| # with api.Environment.manage(): |
There was a problem hiding this comment.
Why do you remove the context manager ?
There was a problem hiding this comment.
Ok, deprecated.
@palkesh-aktivsoftware Could you just remove the unneeded comment ?
There was a problem hiding this comment.
Sure, I made this changes. Please review it.
palkesh-aktivsoftware
force-pushed
the
15.0-mig-contract_payment_mode
branch
from
7c7f40b
to
b47b817
Compare
|
Hi @rousseldenis Can you review again and merge? |
rousseldenis
approved these changes
Aug 16, 2022
|
/ocabot migration contract_payment_mode |
marcelsavegnago
approved these changes
Aug 18, 2022
|
@pedrobaeza @rousseldenis Who wants to merge this? It has a lot of approvals now. :) |
|
/ocabot merge patch |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 040b031. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standard Migration