-
-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[15.0][MIG] contract_payment_mode #811
[15.0][MIG] contract_payment_mode #811
Conversation
* Copy partner payment mode to contracts when installing * Filter payment modes for sales * Adding tests
in recurring invoice
Co-Authored-By: Pedro M. Baeza <[email protected]>
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: contract-12.0/contract-12.0-contract_payment_mode Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract_payment_mode/
Currently translated at 100.0% (2 of 2 strings) Translation: contract-12.0/contract-12.0-contract_payment_mode Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract_payment_mode/ca/
Currently translated at 100.0% (2 of 2 strings) Translation: contract-12.0/contract-12.0-contract_payment_mode Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract_payment_mode/pt_BR/
Currently translated at 100.0% (2 of 2 strings) Translation: contract-12.0/contract-12.0-contract_payment_mode Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract_payment_mode/zh_CN/
Currently translated at 100.0% (2 of 2 strings) Translation: contract-12.0/contract-12.0-contract_payment_mode Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract_payment_mode/de/
Currently translated at 100.0% (2 of 2 strings) Translation: contract-12.0/contract-12.0-contract_payment_mode Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract_payment_mode/pt/
Added view for supplier contracts, respecting the domain for payment_type. Before was showing the inbound types in the supplier payment
Currently translated at 100.0% (5 of 5 strings) Translation: contract-14.0/contract-14.0-contract_payment_mode Translate-URL: https://translation.odoo-community.org/projects/contract-14-0/contract-14-0-contract_payment_mode/es_AR/
Currently translated at 100.0% (2 of 2 strings) Translation: contract-14.0/contract-14.0-contract_payment_mode Translate-URL: https://translation.odoo-community.org/projects/contract-14-0/contract-14-0-contract_payment_mode/it/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review, LGTM!
This PR has the |
contract_payment_mode/hooks.py
Outdated
if payment_mode: | ||
contract.payment_mode_id = payment_mode.id | ||
_logger.info("Setting payment mode: Done") | ||
# with api.Environment.manage(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you remove the context manager ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, deprecated.
@palkesh-aktivsoftware Could you just remove the unneeded comment ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I made this changes. Please review it.
7c7f40b
to
b47b817
Compare
Hi @rousseldenis Can you review again and merge? |
/ocabot migration contract_payment_mode |
@pedrobaeza @rousseldenis Who wants to merge this? It has a lot of approvals now. :) |
/ocabot merge patch |
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at 040b031. Thanks a lot for contributing to OCA. ❤️ |
Standard Migration